Checks if futures are done in AIOHttpClientStreamUnified to avoid race condition #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tagging @jonathan343 since I saw him actively working on https://github.com/awslabs/aws-sdk-python Thanks in advance. |
nicolastomeo
changed the title
Contributor
|
@nicolastomeo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
In Python libraries like https://github.com/awslabs/aws-sdk-python/tree/develop/clients/aws-sdk-transcribe-streaming and https://github.com/awslabs/amazon-transcribe-streaming-sdk where awscrt is used, a few people, me included notice an issue where futures that are already done (cancelled) are being set so an InvalidStateError is raised.
Examples: awslabs/amazon-transcribe-streaming-sdk#61 and awslabs/aws-sdk-python#13
Description of changes:
Just checking if future is not done before setting the result.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.